From 7308f2e9121d90de55da57c9e7ec06ff2b2212bc Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Wed, 29 Jan 2020 10:45:40 +0100 Subject: [PATCH] radv/llvm: enable 8-bit storage features on GFX6-GFX7 It's now supported and all CTS tests pass. Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen Part-of: --- src/amd/vulkan/radv_device.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index e95d6f1e0b8..7bbc8be9b3f 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -1103,10 +1103,9 @@ void radv_GetPhysicalDeviceFeatures2( case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES: { VkPhysicalDevice8BitStorageFeatures *features = (VkPhysicalDevice8BitStorageFeatures *)ext; - bool enabled = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco; - features->storageBuffer8BitAccess = enabled; - features->uniformAndStorageBuffer8BitAccess = enabled; - features->storagePushConstant8 = enabled; + features->storageBuffer8BitAccess = !pdevice->use_aco; + features->uniformAndStorageBuffer8BitAccess = !pdevice->use_aco; + features->storagePushConstant8 = !pdevice->use_aco; break; } case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES: { @@ -1240,9 +1239,9 @@ void radv_GetPhysicalDeviceFeatures2( (VkPhysicalDeviceVulkan12Features *)ext; features->samplerMirrorClampToEdge = true; features->drawIndirectCount = true; - features->storageBuffer8BitAccess = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco; - features->uniformAndStorageBuffer8BitAccess = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco; - features->storagePushConstant8 = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco; + features->storageBuffer8BitAccess = !pdevice->use_aco; + features->uniformAndStorageBuffer8BitAccess = !pdevice->use_aco; + features->storagePushConstant8 = !pdevice->use_aco; features->shaderBufferInt64Atomics = LLVM_VERSION_MAJOR >= 9; features->shaderSharedInt64Atomics = LLVM_VERSION_MAJOR >= 9; features->shaderFloat16 = pdevice->rad_info.chip_class >= GFX8 && !pdevice->use_aco; -- 2.30.2