From 745df74fe0ee57444487c7a231ce02a96244e48d Mon Sep 17 00:00:00 2001 From: Min Kyu Jeong Date: Mon, 15 Nov 2010 14:04:04 -0600 Subject: [PATCH] O3: prevent a squash when completeAcc() modifies misc reg through TC. This happens on ARM instructions when they update the IT state bits. Code and associated comment was copied from execute() and initiateAcc() methods --- src/cpu/o3/dyn_inst_impl.hh | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/cpu/o3/dyn_inst_impl.hh b/src/cpu/o3/dyn_inst_impl.hh index 6f7c23b2f..268746655 100644 --- a/src/cpu/o3/dyn_inst_impl.hh +++ b/src/cpu/o3/dyn_inst_impl.hh @@ -113,8 +113,17 @@ template Fault BaseO3DynInst::completeAcc(PacketPtr pkt) { + // @todo: Pretty convoluted way to avoid squashing from happening + // when using the TC during an instruction's execution + // (specifically for instructions that have side-effects that use + // the TC). Fix this. + bool in_syscall = this->thread->inSyscall; + this->thread->inSyscall = true; + this->fault = this->staticInst->completeAcc(pkt, this, this->traceData); + this->thread->inSyscall = in_syscall; + return this->fault; } -- 2.30.2