From 767ba60831657a684e3852c398a0d13d1201158f Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Tue, 28 Feb 2012 13:33:53 -0800 Subject: [PATCH] mesa: Add missing error check for first < 0 in glDrawArraysInstanced(). Fixes piglit GL_ARB_draw_instanced/negative-arrays-first-negative. Reviewed-by: Kenneth Graunke --- src/mesa/main/api_validate.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index b10d8cd053c..4e94f47e328 100644 --- a/src/mesa/main/api_validate.c +++ b/src/mesa/main/api_validate.c @@ -383,6 +383,12 @@ _mesa_validate_DrawArraysInstanced(struct gl_context *ctx, GLenum mode, GLint fi return GL_FALSE; } + if (first < 0) { + _mesa_error(ctx, GL_INVALID_VALUE, + "glDrawArraysInstanced(start=%d)", first); + return GL_FALSE; + } + if (!_mesa_valid_prim_mode(ctx, mode)) { _mesa_error(ctx, GL_INVALID_ENUM, "glDrawArraysInstanced(mode=0x%x)", mode); -- 2.30.2