From 77fcff37cfdcc762ef0e0c5da3e9ce7addc18440 Mon Sep 17 00:00:00 2001 From: Axel Davy Date: Mon, 5 Jan 2015 16:26:27 +0100 Subject: [PATCH] st/nine: Change comment relating to vertex shader inputs not matching declaration Reviewed-by: Tiziano Bacocco Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium/state_trackers/nine/nine_state.c index 1187a20bdb3..dad665133ac 100644 --- a/src/gallium/state_trackers/nine/nine_state.c +++ b/src/gallium/state_trackers/nine/nine_state.c @@ -214,11 +214,12 @@ update_vertex_elements(struct NineDevice9 *device) if (state->stream_freq[b] & D3DSTREAMSOURCE_INSTANCEDATA) ve[n].instance_divisor = state->stream_freq[b] & 0x7FFFFF; } else { - /* TODO: - * If drivers don't want to handle this, insert a dummy buffer. - * But on which stream ? - */ - /* no data, disable */ + /* TODO: msdn doesn't specify what should happen when the vertex + * declaration doesn't match the vertex shader inputs. + * Some websites say the code will pass but nothing will get rendered. + * We should check and implement the correct behaviour. */ + /* Put PIPE_FORMAT_NONE. + * Some drivers (r300) are very unhappy with that */ ve[n].src_format = PIPE_FORMAT_NONE; ve[n].src_offset = 0; ve[n].instance_divisor = 0; -- 2.30.2