From 7811d01f07061232f52f5f8331ddbba130abac3f Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Thu, 29 Oct 2020 21:54:52 -0700 Subject: [PATCH] dev: Delete the unused DLAB member in the 8250 UART. This value is never actually used. The value is computed from the LCR each time it's needed instead. Change-Id: I6dc5580eb03174f32b8a381cd2974f742b8eb472 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/36817 Reviewed-by: Giacomo Travaglini Maintainer: Giacomo Travaglini Tested-by: kokoro --- src/dev/serial/uart8250.cc | 4 +--- src/dev/serial/uart8250.hh | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/dev/serial/uart8250.cc b/src/dev/serial/uart8250.cc index 10dc08e95..9f93024a4 100644 --- a/src/dev/serial/uart8250.cc +++ b/src/dev/serial/uart8250.cc @@ -84,7 +84,7 @@ Uart8250::scheduleIntr(Event *event) Uart8250::Uart8250(const Params &p) - : Uart(p, 8), IER(0), DLAB(0), LCR(0), MCR(0), lastTxInt(0), + : Uart(p, 8), IER(0), LCR(0), MCR(0), lastTxInt(0), txIntrEvent([this]{ processIntrEvent(TX_INT); }, "TX"), rxIntrEvent([this]{ processIntrEvent(RX_INT); }, "RX") { @@ -285,7 +285,6 @@ Uart8250::serialize(CheckpointOut &cp) const { SERIALIZE_SCALAR(status); SERIALIZE_SCALAR(IER); - SERIALIZE_SCALAR(DLAB); SERIALIZE_SCALAR(LCR); SERIALIZE_SCALAR(MCR); Tick rxintrwhen; @@ -307,7 +306,6 @@ Uart8250::unserialize(CheckpointIn &cp) { UNSERIALIZE_SCALAR(status); UNSERIALIZE_SCALAR(IER); - UNSERIALIZE_SCALAR(DLAB); UNSERIALIZE_SCALAR(LCR); UNSERIALIZE_SCALAR(MCR); Tick rxintrwhen; diff --git a/src/dev/serial/uart8250.hh b/src/dev/serial/uart8250.hh index 3209416c6..b18079d57 100644 --- a/src/dev/serial/uart8250.hh +++ b/src/dev/serial/uart8250.hh @@ -68,7 +68,7 @@ class Platform; class Uart8250 : public Uart { protected: - uint8_t IER, DLAB, LCR, MCR; + uint8_t IER, LCR, MCR; Tick lastTxInt; void processIntrEvent(int intrBit); -- 2.30.2