From 783cecc8b3b4aeb00b901cdc0883f93839ac222b Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Mon, 4 Aug 2014 14:26:25 +0800 Subject: [PATCH] Remove pst from dwarf_decode_lines_1 Hi, Parameter 'pst' of function dwarf_decode_lines_1 isn't used except to compute decode_for_pst_p, which has been got in the caller dwarf_decode_lines. I wonder it would be good if we just pass 'decode_for_pst_p'. gdb: 2014-08-15 Yao Qi * dwarf2read.c (dwarf_decode_lines_1): Remove parameter 'pst'. Add parameter 'decode_for_pst_p'. Callers update. --- gdb/ChangeLog | 5 +++++ gdb/dwarf2read.c | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6a119018025..53cc6153a1f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-08-15 Yao Qi + + * dwarf2read.c (dwarf_decode_lines_1): Remove parameter 'pst'. + Add parameter 'decode_for_pst_p'. Callers update. + 2014-08-13 Yao Qi PR build/17104 diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index abe47d100c7..cb68a4a3f34 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -17177,7 +17177,7 @@ noop_record_line (struct subfile *subfile, int line, CORE_ADDR pc) static void dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir, - struct dwarf2_cu *cu, struct partial_symtab *pst) + struct dwarf2_cu *cu, const int decode_for_pst_p) { const gdb_byte *line_ptr, *extended_end; const gdb_byte *line_end; @@ -17187,7 +17187,6 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir, struct objfile *objfile = cu->objfile; bfd *abfd = objfile->obfd; struct gdbarch *gdbarch = get_objfile_arch (objfile); - const int decode_for_pst_p = (pst != NULL); struct subfile *last_subfile = NULL; void (*p_record_line) (struct subfile *subfile, int line, CORE_ADDR pc) = record_line; @@ -17501,7 +17500,7 @@ dwarf_decode_lines (struct line_header *lh, const char *comp_dir, struct subfile *first_subfile = current_subfile; if (want_line_info) - dwarf_decode_lines_1 (lh, comp_dir, cu, pst); + dwarf_decode_lines_1 (lh, comp_dir, cu, decode_for_pst_p); if (decode_for_pst_p) { -- 2.30.2