From 78615dcca19699737bf9cbc784b66d9ea966bcc0 Mon Sep 17 00:00:00 2001 From: Christopher Egert Date: Fri, 15 May 2020 16:41:15 +0200 Subject: [PATCH] radv: use util_float_to_half_rtz Since commit 8b8af6d398a94cb07015c695fdfdb5c157aa72cf there is a performance regression in dirt 4 on picasso APUs. The game ends up feeding a large value into this which overflows on the conversion to 16bit float. With the old implementation (which now lives in util_float_to_half_rtz) it would be clamped to inf-1, while the new one returns inf. This causes a performance hit somehow at some point down the line. Reviewed-by: Bas Nieuwenhuizen Fixes: 8b8af6d398a "gallium/util: Switch util_float_to_half to _mesa_float_to_half()'s impl." Part-of: --- src/amd/vulkan/radv_formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index a790459c900..badfcc4f72f 100644 --- a/src/amd/vulkan/radv_formats.c +++ b/src/amd/vulkan/radv_formats.c @@ -1060,7 +1060,7 @@ bool radv_format_pack_clear_color(VkFormat format, if (channel->size == 32) { memcpy(&v, &value->float32[c], 4); } else if(channel->size == 16) { - v = util_float_to_half(value->float32[c]); + v = util_float_to_half_rtz(value->float32[c]); } else { fprintf(stderr, "failed to fast clear for unhandled float size in format %d\n", format); return false; -- 2.30.2