From 788c80d1aff685e66b8105ddc7451cfa6a03bf1d Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 1 Mar 2019 19:56:45 -0700 Subject: [PATCH] Remove some unneeded initializations in minimal_symbol_reader minimal_symbol_reader::record_full does not need to initialize any minsym fields to 0, because that was already done implicitly via the use of XCNEW when allocating the msym_bunch. gdb/ChangeLog 2019-03-15 Tom Tromey * minsyms.c (minimal_symbol_reader::record_full): Remove some initializations. --- gdb/ChangeLog | 5 +++++ gdb/minsyms.c | 10 ---------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 867df178839..ceedf536e56 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-03-15 Tom Tromey + + * minsyms.c (minimal_symbol_reader::record_full): Remove some + initializations. + 2019-03-15 Tom Tromey * objfiles.h (struct objfile_per_bfd_storage) diff --git a/gdb/minsyms.c b/gdb/minsyms.c index cbb45f141c9..bc6e536de87 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -1163,16 +1163,6 @@ minimal_symbol_reader::record_full (const char *name, int name_len, MSYMBOL_SECTION (msymbol) = section; MSYMBOL_TYPE (msymbol) = ms_type; - MSYMBOL_TARGET_FLAG_1 (msymbol) = 0; - MSYMBOL_TARGET_FLAG_2 (msymbol) = 0; - /* Do not use the SET_MSYMBOL_SIZE macro to initialize the size, - as it would also set the has_size flag. */ - msymbol->size = 0; - - /* The hash pointers must be cleared! If they're not, - add_minsym_to_hash_table will NOT add this msymbol to the hash table. */ - msymbol->hash_next = NULL; - msymbol->demangled_hash_next = NULL; /* If we already read minimal symbols for this objfile, then don't ever allocate a new one. */ -- 2.30.2