From 789c4b5ea14b0c441e6021f07503e61ccfacb427 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 4 May 2017 21:25:55 -0600 Subject: [PATCH] Change captured_mi_execute_command to use scoped_restore Change captured_mi_execute_command to use a scoped_restore, removing a cleanup. The old code copied the current token, but I don't believe that is necessary. gdb/ChangeLog 2017-09-29 Tom Tromey * mi/mi-main.c (captured_mi_execute_command): Use scope_restore. --- gdb/ChangeLog | 4 ++++ gdb/mi/mi-main.c | 9 +++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index db456b3d116..005e366488e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-09-29 Tom Tromey + + * mi/mi-main.c (captured_mi_execute_command): Use scope_restore. + 2017-09-29 Tom Tromey * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions): Update. diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index 4d9f37b2bd9..29acf2df0bf 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -1875,20 +1875,19 @@ mi_cmd_remove_inferior (const char *command, char **argv, int argc) Return <0 for error; >=0 for ok. args->action will tell mi_execute_command what action - to perfrom after the given command has executed (display/suppress + to perform after the given command has executed (display/suppress prompt, display error). */ static void captured_mi_execute_command (struct ui_out *uiout, struct mi_parse *context) { struct mi_interp *mi = (struct mi_interp *) command_interp (); - struct cleanup *cleanup; if (do_timings) current_command_ts = context->cmd_start; - current_token = xstrdup (context->token); - cleanup = make_cleanup (free_current_contents, ¤t_token); + scoped_restore save_token = make_scoped_restore (¤t_token, + context->token); running_result_record_printed = 0; mi_proceeded = 0; @@ -1964,8 +1963,6 @@ captured_mi_execute_command (struct ui_out *uiout, struct mi_parse *context) break; } } - - do_cleanups (cleanup); } /* Print a gdb exception to the MI output stream. */ -- 2.30.2