From 79926e5a904598f638dc258d727babfcda28c0ac Mon Sep 17 00:00:00 2001 From: Ed Schonberg Date: Mon, 15 Jun 2020 17:40:26 -0400 Subject: [PATCH] [Ada] Warnings on overloays involving generic In_Parameters gcc/ada/ * sem_ch13.adb (Analyze_Address_Specification_Clause): Do not emit a warning when a constant declaration in a generic unit overlays a generic In_Parameter. --- gcc/ada/sem_ch13.adb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/ada/sem_ch13.adb b/gcc/ada/sem_ch13.adb index ec25e3d6eb4..6927d54fc5f 100644 --- a/gcc/ada/sem_ch13.adb +++ b/gcc/ada/sem_ch13.adb @@ -6190,9 +6190,13 @@ package body Sem_Ch13 is -- Issue an unconditional warning for a constant overlaying -- a variable. For the reverse case, we will issue it only -- if the variable is modified. + -- Within a generic unit an In_Parameter is a constant. + -- It can be instantiated with a variable, in which case + -- there will be a warning on the instance. if Ekind (U_Ent) = E_Constant and then Present (O_Ent) + and then Ekind (O_Ent) /= E_Generic_In_Parameter and then not Overlays_Constant (U_Ent) and then Address_Clause_Overlay_Warnings then -- 2.30.2