From 7b4387519c382cffef9c62bbbbefcfe71cfde905 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Wed, 1 Nov 2017 07:57:21 -0700 Subject: [PATCH] intel/fs: Alloc pull constants off mem_ctx MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some error cases. Reviewed-by: Lionel Landwerlin Reviewed-by: Tapani Pälli Cc: mesa-stable@lists.freedesktop.org --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 814da8ad94d..e2176827a64 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -2095,7 +2095,7 @@ fs_visitor::assign_constant_locations() stage_prog_data->param = ralloc_array(mem_ctx, uint32_t, num_push_constants); if (num_pull_constants > 0) { stage_prog_data->nr_pull_params = num_pull_constants; - stage_prog_data->pull_param = ralloc_array(NULL, uint32_t, + stage_prog_data->pull_param = ralloc_array(mem_ctx, uint32_t, num_pull_constants); } -- 2.30.2