From 7b85b9b8773b119360a31b66b321ae560a77cb6d Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Thu, 23 Nov 2017 13:16:43 +0000 Subject: [PATCH] compiler: use NDEBUG to guard asserts nir_validate.c's #endif already had the correct NDEBUG comment Fixes: dcb1acdea00a8f2c29777 "nir/validate: Only build in debug mode" Fixes: 9ff71b649b4b3808a9e17 "i965/nir: Validate that NIR passes call nir_metadata_preserve()" Signed-off-by: Eric Engestrom Reviewed-by: Matt Turner --- src/compiler/nir/nir.h | 8 ++++---- src/compiler/nir/nir_metadata.c | 2 +- src/compiler/nir/nir_validate.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index cf200fdc665..c01fa6707a4 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -41,9 +41,9 @@ #include "compiler/shader_info.h" #include -#ifdef DEBUG +#ifndef NDEBUG #include "util/debug.h" -#endif /* DEBUG */ +#endif /* NDEBUG */ #include "nir_opcodes.h" @@ -2336,7 +2336,7 @@ nir_deref_var *nir_deref_var_clone(const nir_deref_var *deref, void *mem_ctx); nir_shader *nir_shader_serialize_deserialize(void *mem_ctx, nir_shader *s); -#ifdef DEBUG +#ifndef NDEBUG void nir_validate_shader(nir_shader *shader); void nir_metadata_set_validation_flag(nir_shader *shader); void nir_metadata_check_validation_flag(nir_shader *shader); @@ -2377,7 +2377,7 @@ static inline void nir_metadata_check_validation_flag(nir_shader *shader) { (voi static inline bool should_clone_nir(void) { return false; } static inline bool should_serialize_deserialize_nir(void) { return false; } static inline bool should_print_nir(void) { return false; } -#endif /* DEBUG */ +#endif /* NDEBUG */ #define _PASS(nir, do_pass) do { \ do_pass \ diff --git a/src/compiler/nir/nir_metadata.c b/src/compiler/nir/nir_metadata.c index f71cf432b70..e681ba34f75 100644 --- a/src/compiler/nir/nir_metadata.c +++ b/src/compiler/nir/nir_metadata.c @@ -59,7 +59,7 @@ nir_metadata_preserve(nir_function_impl *impl, nir_metadata preserved) impl->valid_metadata &= preserved; } -#ifdef DEBUG +#ifndef NDEBUG /** * Make sure passes properly invalidate metadata (part 1). * diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c index 9bf8c702901..a49948fbb48 100644 --- a/src/compiler/nir/nir_validate.c +++ b/src/compiler/nir/nir_validate.c @@ -35,7 +35,7 @@ /* Since this file is just a pile of asserts, don't bother compiling it if * we're not building a debug build. */ -#ifdef DEBUG +#ifndef NDEBUG /* * Per-register validation state. -- 2.30.2