From 7beb7f68a0514c489f8305b79ce3938a6a4e54f9 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 4 Apr 2016 10:31:30 -0400 Subject: [PATCH] Fix gdb.mi/mi-breakpoint-changed.exp for remote targets The libraries are never downloaded to the target for the first test (test_insert_delete_modify), so the executable can't run properly. I also added some with_test_prefix to help differentiate between the different test case phases. gdb/testsuite/ChangeLog: * gdb.mi/mi-breakpoint-changed.exp: Add some with_test_prefix. (test_insert_delete_modify): Call mi_load_shlibs before trying to run. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp | 11 +++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index c4338ff49e3..ec99787cd57 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2016-04-04 Simon Marchi + + * gdb.mi/mi-breakpoint-changed.exp: Add some with_test_prefix. + (test_insert_delete_modify): Call mi_load_shlibs before trying to + run. + 2016-04-01 Artemiy Volkov PR gdb/19820 diff --git a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp index c12f8b8789d..cda8c4a3e2b 100644 --- a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp +++ b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp @@ -45,12 +45,15 @@ if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable $exec_opts] != "" proc test_insert_delete_modify { } { global mi_gdb_prompt + global lib_sl1 lib_sl2 gdb_exit if [mi_gdb_start] { continue } + mi_load_shlibs $lib_sl1 $lib_sl2 + mi_run_to_main mi_gdb_test "break marker" \ @@ -150,7 +153,9 @@ proc test_insert_delete_modify { } { } } -test_insert_delete_modify +with_test_prefix "test_insert_delete_modify" { + test_insert_delete_modify +} # Test 'breakpoint-modified' notification is emited when pending breakpoints are # resolved. @@ -251,4 +256,6 @@ proc test_pending_resolved { } { } } -test_pending_resolved +with_test_prefix "test_pending_resolved" { + test_pending_resolved +} -- 2.30.2