From 7c40cdc12f4f5aaf8361de5bb0e7939b585481c4 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Thu, 7 Jun 2018 02:28:56 -0700 Subject: [PATCH] iris: comment about reemitting and flushing --- src/gallium/drivers/iris/iris_draw.c | 5 ++++- src/gallium/drivers/iris/iris_program.c | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/iris/iris_draw.c b/src/gallium/drivers/iris/iris_draw.c index 5295f2ac847..9101d7a58ab 100644 --- a/src/gallium/drivers/iris/iris_draw.c +++ b/src/gallium/drivers/iris/iris_draw.c @@ -40,6 +40,7 @@ iris_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info) iris_batch_maybe_flush(batch, 1500); // XXX: actually do brw_cache_flush_for_* + // XXX: CS stall is really expensive iris_emit_pipe_control_flush(batch, PIPE_CONTROL_DEPTH_CACHE_FLUSH | PIPE_CONTROL_RENDER_TARGET_FLUSH | @@ -56,6 +57,8 @@ iris_draw_vbo(struct pipe_context *ctx, const struct pipe_draw_info *info) iris_binder_reserve_3d(batch, ice->shaders.prog); ice->vtbl.upload_render_state(ice, batch, info); + // XXX: ice->state.dirty = 0ull; + // XXX: don't flush always - iris_batch_flush(batch); + //iris_batch_flush(batch); } diff --git a/src/gallium/drivers/iris/iris_program.c b/src/gallium/drivers/iris/iris_program.c index 59fcbed6302..669754e8aaf 100644 --- a/src/gallium/drivers/iris/iris_program.c +++ b/src/gallium/drivers/iris/iris_program.c @@ -464,6 +464,7 @@ iris_update_compiled_shaders(struct iris_context *ice) old_prog_datas[i] = get_vue_prog_data(ice, i); } + // XXX: dirty bits... iris_update_compiled_vs(ice); iris_update_compiled_tcs(ice); iris_update_compiled_tes(ice); -- 2.30.2