From 7c8434889d8d08ae3c5d2287d1d6c5e03159e9f9 Mon Sep 17 00:00:00 2001 From: Tomeu Vizoso Date: Wed, 31 Jul 2019 16:29:25 +0200 Subject: [PATCH] panfrost: Mark buffers as PANFROST_BO_HEAP What we call GROWABLE in Mesa corresponds to the HEAP BO flag in the kernel. These buffers cannot be memory mapped in the CPU side at the moment, so make sure they are also marked INVISIBLE. This allows us to allocate a big heap upfront (16MB) without actually reserving space unless it's needed. Signed-off-by: Tomeu Vizoso Reviewed-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_drm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index 6d1e0c08d33..71eda2d1e32 100644 --- a/src/gallium/drivers/panfrost/pan_drm.c +++ b/src/gallium/drivers/panfrost/pan_drm.c @@ -91,10 +91,16 @@ panfrost_drm_create_bo(struct panfrost_screen *screen, size_t size, /* To maximize BO cache usage, don't allocate tiny BOs */ size = MAX2(size, 4096); + /* GROWABLE BOs cannot be mmapped */ + if (flags & PAN_ALLOCATE_GROWABLE) + assert(flags & PAN_ALLOCATE_INVISIBLE); + unsigned translated_flags = 0; if (screen->kernel_version->version_major > 1 || screen->kernel_version->version_minor >= 1) { + if (flags & PAN_ALLOCATE_GROWABLE) + translated_flags |= PANFROST_BO_HEAP; if (!(flags & PAN_ALLOCATE_EXECUTE)) translated_flags |= PANFROST_BO_NOEXEC; } -- 2.30.2