From 7d7990cf657550be4d038a0424ffdc0ef7fd8faa Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Sun, 13 Mar 2016 19:15:45 -0700 Subject: [PATCH] i965/vec4: Consider removal of no-op MOVs as progress during register coalesce. Bug found by the liveness analysis validation pass that will be introduced in a later commit. The no-op MOV check in opt_register_coalesce() was removing instructions which makes the cached liveness analysis calculation inconsistent with the shader IR. We were failing to set progress to true in that case though, which means that invalidate_live_intervals() wouldn't necessarily be called at the end of the function. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index cf62ed9a9d6..baf72a25c42 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp @@ -1051,6 +1051,7 @@ vec4_visitor::opt_register_coalesce() if (is_nop_mov) { inst->remove(block); + progress = true; continue; } } -- 2.30.2