From 7da6a5b938b426379f61e56e259a925bedfe242b Mon Sep 17 00:00:00 2001 From: Luis Machado Date: Fri, 6 Dec 2019 18:12:37 -0300 Subject: [PATCH] Fix/Update misc comments While doing some investigation of mine, i noticed a few typos, inaccuracies and missing information. I went ahead and updated/improved those. gdb/ChangeLog: 2020-01-14 Luis Machado * inf-ptrace.c (inf_ptrace_target::resume): Update comments. * infrun.c (resume_1): Likewise. (handle_inferior_event): Remove stale comment. * linux-nat.c (linux_nat_target::resume): Update comments. (save_stop_reason): Likewise. (linux_nat_filter_event): Likewise. * linux-nat.h (struct lwp_info) , : Likewise. --- gdb/ChangeLog | 10 ++++++++++ gdb/inf-ptrace.c | 8 ++++---- gdb/infrun.c | 8 +++----- gdb/linux-nat.c | 9 +++++---- gdb/linux-nat.h | 4 ++-- 5 files changed, 24 insertions(+), 15 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index fc4920ee643..545cfb36ce1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,13 @@ +2020-01-14 Luis Machado + + * inf-ptrace.c (inf_ptrace_target::resume): Update comments. + * infrun.c (resume_1): Likewise. + (handle_inferior_event): Remove stale comment. + * linux-nat.c (linux_nat_target::resume): Update comments. + (save_stop_reason): Likewise. + (linux_nat_filter_event): Likewise. + * linux-nat.h (struct lwp_info) , : Likewise. + 2020-01-13 Andrew Burgess * elfread.c (record_minimal_symbol): Set section index to 0 for diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c index ecd82ada4ed..db17a76d946 100644 --- a/gdb/inf-ptrace.c +++ b/gdb/inf-ptrace.c @@ -354,10 +354,10 @@ inf_ptrace_target::resume (ptid_t ptid, int step, enum gdb_signal signal) if (step) { /* If this system does not support PT_STEP, a higher level - function will have called single_step() to transmute the step - request into a continue request (by setting breakpoints on - all possible successor instructions), so we don't have to - worry about that here. */ + function will have called the appropriate functions to transmute the + step request into a continue request (by setting breakpoints on + all possible successor instructions), so we don't have to + worry about that here. */ request = PT_STEP; } diff --git a/gdb/infrun.c b/gdb/infrun.c index a8636284f18..1312328b8ff 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -2429,8 +2429,8 @@ resume_1 (enum gdb_signal sig) if (tp->control.trap_expected || bpstat_should_step ()) tp->control.may_range_step = 0; - /* If enabled, step over breakpoints by executing a copy of the - instruction at a different address. + /* If displaced stepping is enabled, step over breakpoints by executing a + copy of the instruction at a different address. We can't use displaced stepping when we have a signal to deliver; the comments for displaced_step_prepare explain why. The @@ -2518,7 +2518,7 @@ resume_1 (enum gdb_signal sig) && step_over_info_valid_p ()) { /* If we have nested signals or a pending signal is delivered - immediately after a handler returns, might might already have + immediately after a handler returns, might already have a step-resume breakpoint set on the earlier handler. We cannot set another step-resume breakpoint; just continue on until the original breakpoint is hit. */ @@ -5297,8 +5297,6 @@ Cannot fill $_exitsignal with the correct signal number.\n")); stop_waiting (ecs); return; - /* The following are the only cases in which we keep going; - the above cases end in a continue or goto. */ case TARGET_WAITKIND_FORKED: case TARGET_WAITKIND_VFORKED: /* Check whether the inferior is displaced stepping. */ diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 66004e5be81..e7533a99309 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -1700,7 +1700,8 @@ linux_nat_target::resume (ptid_t ptid, int step, enum gdb_signal signo) resume_many = (minus_one_ptid == ptid || ptid.is_pid ()); - /* Mark the lwps we're resuming as resumed. */ + /* Mark the lwps we're resuming as resumed and update their + last_resume_kind to resume_continue. */ iterate_over_lwps (ptid, resume_set_callback); /* See if it's the current inferior that should be handled @@ -2725,7 +2726,7 @@ save_stop_reason (struct lwp_info *lp) { /* If we determine the LWP stopped for a SW breakpoint, trust it. Particularly don't check watchpoint - registers, because at least on s390, we'd find + registers, because, at least on s390, we'd find stopped-by-watchpoint as long as there's a watchpoint set. */ lp->stop_reason = TARGET_STOPPED_BY_SW_BREAKPOINT; @@ -2929,7 +2930,7 @@ resumed_callback (struct lwp_info *lp) } /* Check if we should go on and pass this event to common code. - Return the affected lwp if we are, or NULL otherwise. */ + Return the affected lwp if we should, or NULL otherwise. */ static struct lwp_info * linux_nat_filter_event (int lwpid, int status) @@ -3122,7 +3123,7 @@ linux_nat_filter_event (int lwpid, int status) /* Don't report signals that GDB isn't interested in, such as signals that are neither printed nor stopped upon. Stopping all - threads can be a bit time-consuming so if we want decent + threads can be a bit time-consuming, so if we want decent performance with heavily multi-threaded programs, especially when they're using a high frequency timer, we'd better avoid it if we can. */ diff --git a/gdb/linux-nat.h b/gdb/linux-nat.h index e02611fcf14..f800e439979 100644 --- a/gdb/linux-nat.h +++ b/gdb/linux-nat.h @@ -229,7 +229,7 @@ struct lwp_info /* When 'stopped' is set, this is where the lwp last stopped, with decr_pc_after_break already accounted for. If the LWP is - running, and stepping, this is the address at which the lwp was + running and stepping, this is the address at which the lwp was resumed (that is, it's the previous stop PC). If the LWP is running and not stepping, this is 0. */ CORE_ADDR stop_pc; @@ -238,7 +238,7 @@ struct lwp_info int step; /* The reason the LWP last stopped, if we need to track it - (breakpoint, watchpoint, etc.) */ + (breakpoint, watchpoint, etc.). */ enum target_stop_reason stop_reason; /* On architectures where it is possible to know the data address of -- 2.30.2