From 7dbfcb91a87f78446c5e10582d4ea9ea168f3f98 Mon Sep 17 00:00:00 2001 From: Alexandre Oliva Date: Wed, 8 Apr 2020 14:24:29 -0300 Subject: [PATCH] add missing fp16 options dg-require-effective-target arm_fp16_alternative_ok may pass even when arm_fp16_ok doesn't, and the latter's failure inhibits dg-add-options arm_fp16_alternative. Requiring arm_fp16_ok would disable the test, but if we just pass it the -mfp16-format=alternative option, it passes even without arm_fp16_ok. Sibling test fp16-aapcs-4.c underwent a similar change, so I'm proposing the explicit option to fp16-aapcs-3.c as well. for gcc/testsuite/ChangeLog * gcc.target/arm/fp16-aapcs-3.c: Explicitly use the -mfp16-format=alternative option. --- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.target/arm/fp16-aapcs-3.c | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index e8305cb1c33..db4f6392493 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-04-08 Alexandre Oliva + + * gcc.target/arm/fp16-aapcs-3.c: Explicitly use the + -mfp16-format=alternative option. + 2020-04-08 H.J. Lu PR target/94417 diff --git a/gcc/testsuite/gcc.target/arm/fp16-aapcs-3.c b/gcc/testsuite/gcc.target/arm/fp16-aapcs-3.c index 56a3ae26184..858181cdd85 100644 --- a/gcc/testsuite/gcc.target/arm/fp16-aapcs-3.c +++ b/gcc/testsuite/gcc.target/arm/fp16-aapcs-3.c @@ -1,8 +1,7 @@ /* { dg-do compile } */ /* { dg-require-effective-target arm_hard_vfp_ok } */ /* { dg-require-effective-target arm_fp16_alternative_ok } */ -/* { dg-options "-O2" } */ -/* { dg-add-options arm_fp16_alternative } */ +/* { dg-options "-O2 -mfp16-format=alternative" } */ /* Test __fp16 arguments and return value in registers (hard-float). */ -- 2.30.2