From 7dfa3b3fb42adabe5bbf36ea32909f427561ca59 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Wed, 28 Apr 2010 23:40:42 +0200 Subject: [PATCH] autotools: fix autoreconf check The autoreconf check was incorrect, missing a $ sign to properly reference a package-specific variable. There was no visible effect until now since : * The existing syntax allowed to access the value defined in the package specific .mk file, so when AUTORECONF was set to YES by a package, it was working. * The default value in Makefile.autotools.in was NO. In fact, when a package .mkf file wasn't defining the AUTORECONF variable, the Makefile.autotools.in test was testing the empty string against 'YES', which was false, leading to the AUTORECONF not being done, which was the desired effect. However, in a later patch, we intend to change this default value. Signed-off-by: Thomas Petazzoni Signed-off-by: Peter Korsgaard --- package/Makefile.autotools.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in index b7a7103594..fc5bcee343 100644 --- a/package/Makefile.autotools.in +++ b/package/Makefile.autotools.in @@ -162,7 +162,7 @@ define AUTORECONF_HOOK fi endef -ifeq ($($(2)_AUTORECONF),YES) +ifeq ($$($(2)_AUTORECONF),YES) $(2)_POST_PATCH_HOOKS += AUTORECONF_HOOK $(2)_DEPENDENCIES += host-automake host-autoconf host-libtool endif -- 2.30.2