From 7e8d4ab4d1db50fe54dbc90d632c07e98b869d55 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 11 Jul 2002 01:07:49 +0000 Subject: [PATCH] * config/tc-ppc.c (ppc_elf_frob_symbol): Delete. (ppc_frob_file_before_adjust): New function. * config/tc-ppc.h (tc_frob_symbol): Don't define. (ppc_elf_frob_symbol): Don't declare. (tc_frob_file_before_adjust): Define. (ppc_frob_file_before_adjust): Declare. --- gas/ChangeLog | 7 +++++++ gas/config/tc-ppc.c | 48 +++++++++++++++++++++++++++++++++++---------- gas/config/tc-ppc.h | 5 ++--- 3 files changed, 47 insertions(+), 13 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index e8b9b01b838..17717417b13 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,5 +1,12 @@ 2002-07-11 Alan Modra + * config/tc-ppc.c (ppc_elf_frob_symbol): Delete. + (ppc_frob_file_before_adjust): New function. + * config/tc-ppc.h (tc_frob_symbol): Don't define. + (ppc_elf_frob_symbol): Don't declare. + (tc_frob_file_before_adjust): Define. + (ppc_frob_file_before_adjust): Declare. + * config/tc-ppc.c (md_pseudo_table): Warning fix. (ppc_cpu): Make it unsigned long to agree with struct powerpc_opcode flags. diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c index b73d30cff51..68f8764bf5f 100644 --- a/gas/config/tc-ppc.c +++ b/gas/config/tc-ppc.c @@ -1688,21 +1688,49 @@ ppc_elf_validate_fix (fixp, seg) } } -/* Don't emit .TOC. symbol. */ -int -ppc_elf_frob_symbol (sym) - symbolS *sym; +/* Prevent elf_frob_file_before_adjust removing a weak undefined + function descriptor sym if the corresponding code sym is used. */ + +void +ppc_frob_file_before_adjust () { - const char *name; + symbolS *symp; + + if (!ppc_obj64) + return; - name = S_GET_NAME (sym); - if (name != NULL && strcmp (name, ".TOC.") == 0) + for (symp = symbol_rootP; symp; symp = symbol_next (symp)) { - S_CLEAR_EXTERNAL (sym); - return 1; + const char *name; + char *dotname; + symbolS *dotsym; + size_t len; + + name = S_GET_NAME (symp); + if (name[0] == '.') + continue; + + if (! S_IS_WEAK (symp) + || S_IS_DEFINED (symp)) + continue; + + len = strlen (name) + 1; + dotname = xmalloc (len + 1); + dotname[0] = '.'; + memcpy (dotname + 1, name, len); + dotsym = symbol_find (dotname); + free (dotname); + if (dotsym != NULL && (symbol_used_p (dotsym) + || symbol_used_in_reloc_p (dotsym))) + { + symbol_mark_used (symp); + } } - return 0; + /* Don't emit .TOC. symbol. */ + symp = symbol_find (".TOC."); + if (symp != NULL) + symbol_remove (symp, &symbol_rootP, &symbol_lastP); } #endif /* OBJ_ELF */ diff --git a/gas/config/tc-ppc.h b/gas/config/tc-ppc.h index f05f8e7a08e..b6dd64065f1 100644 --- a/gas/config/tc-ppc.h +++ b/gas/config/tc-ppc.h @@ -271,9 +271,8 @@ extern int ppc_fix_adjustable PARAMS ((struct fix *)); && S_IS_DEFINED ((FIX)->fx_addsy) \ && ! S_IS_COMMON ((FIX)->fx_addsy))) -/* Finish up the symbol. */ -#define tc_frob_symbol(sym, punt) punt = ppc_elf_frob_symbol (sym) -extern int ppc_elf_frob_symbol PARAMS ((symbolS *)); +#define tc_frob_file_before_adjust ppc_frob_file_before_adjust +extern void ppc_frob_file_before_adjust PARAMS ((void)); #define DWARF2_LINE_MIN_INSN_LENGTH 4 #endif /* OBJ_ELF */ -- 2.30.2