From 7ef412cf72a197d68e532604cc1fa21351adc858 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Sat, 11 Jan 2020 12:23:47 +1030 Subject: [PATCH] ubsan: xgate: left shift of negative value * xgate-dis.c (print_insn): Don't left shift signed value. (ripBits): Formatting, use 1u. --- opcodes/ChangeLog | 5 +++++ opcodes/xgate-dis.c | 16 ++++++++-------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 68538bd0392..e2e9b10fcdd 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,8 @@ +2020-01-13 Alan Modra + + * xgate-dis.c (print_insn): Don't left shift signed value. + (ripBits): Formatting, use 1u. + 2020-01-10 Alan Modra * tilepro-opc.c (parse_insn_tilepro): Make opval unsigned. diff --git a/opcodes/xgate-dis.c b/opcodes/xgate-dis.c index 9d84431978e..61eeb9971c6 100644 --- a/opcodes/xgate-dis.c +++ b/opcodes/xgate-dis.c @@ -193,12 +193,12 @@ print_insn (bfd_vma memaddr, struct disassemble_info* info) relAddr = XGATE_NINE_BITS >> 1; /* Clip sign bit. */ relAddr = ~relAddr; /* Make signed. */ relAddr |= (raw_code & 0xFF) + 1; /* Apply our value. */ - relAddr <<= 1; /* Multiply by two as per processor docs. */ + relAddr *= 2; /* Multiply by two as per processor docs. */ } else { relAddr = raw_code & 0xff; - relAddr = (relAddr << 1) + 2; + relAddr = relAddr * 2 + 2; } (*info->fprintf_func)(info->stream, " *%d", relAddr); (*info->fprintf_func)(info->stream, " Abs* 0x"); @@ -212,12 +212,12 @@ print_insn (bfd_vma memaddr, struct disassemble_info* info) relAddr = XGATE_TEN_BITS >> 1; /* Clip sign bit. */ relAddr = ~relAddr; /* Make signed. */ relAddr |= (raw_code & 0x1FF) + 1; /* Apply our value. */ - relAddr <<= 1; /* Multiply by two as per processor docs. */ + relAddr *= 2; /* Multiply by two as per processor docs. */ } else { relAddr = raw_code & 0x1FF; - relAddr = (relAddr << 1) + 2; + relAddr = relAddr * 2 + 2; } (*info->fprintf_func)(info->stream, " *%d", relAddr); (*info->fprintf_func)(info->stream, " Abs* 0x"); @@ -299,12 +299,12 @@ ripBits (unsigned int *operandBitsRemaining, unsigned int memory) { unsigned int currentBit; - int operand; + unsigned int operand = 0; int numBitsFound; - for (operand = 0, numBitsFound = 0, currentBit = 1 - << ((opcodePTR->size * 8) - 1); - (numBitsFound < numBitsRequested) && currentBit; currentBit >>= 1) + for (numBitsFound = 0, currentBit = 1u << ((opcodePTR->size * 8) - 1); + numBitsFound < numBitsRequested && currentBit != 0; + currentBit >>= 1) { if (currentBit & *operandBitsRemaining) { -- 2.30.2