From 7f1f7ffb496174346fd73b93ebaf12ee4a26685f Mon Sep 17 00:00:00 2001 From: Tobias Burnus Date: Fri, 21 Jan 2011 08:11:05 +0100 Subject: [PATCH] re PR fortran/47377 (internal compiler error: in fold_convert_loc, at fold-const.c:1906) 2011-01-21 Tobias Burnus PR fortran/47377 * expr.c (gfc_check_pointer_assign): Reject expr data-targets without pointer attribute. 2011-01-21 Tobias Burnus PR fortran/47377 * gfortran.dg/pointer_target_4.f90: New. From-SVN: r169079 --- gcc/fortran/ChangeLog | 6 ++++++ gcc/fortran/expr.c | 9 +++++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gfortran.dg/pointer_target_4.f90 | 15 +++++++++++++++ 4 files changed, 35 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pointer_target_4.f90 diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index 8bf90a95b04..7ea96036e7f 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,9 @@ +2011-01-21 Tobias Burnus + + PR fortran/47377 + * expr.c (gfc_check_pointer_assign): Reject expr data-targets + without pointer attribute. + 2011-01-18 Janus Weil PR fortran/47240 diff --git a/gcc/fortran/expr.c b/gcc/fortran/expr.c index 3f1141a0e0b..bcc23fc325a 100644 --- a/gcc/fortran/expr.c +++ b/gcc/fortran/expr.c @@ -3507,6 +3507,15 @@ gfc_check_pointer_assign (gfc_expr *lvalue, gfc_expr *rvalue) lvalue->symtree->n.sym->attr.subref_array_pointer = 1; attr = gfc_expr_attr (rvalue); + + if (rvalue->expr_type == EXPR_FUNCTION && !attr.pointer) + { + gfc_error ("Target expression in pointer assignment " + "at %L must deliver a pointer result", + &rvalue->where); + return FAILURE; + } + if (!attr.target && !attr.pointer) { gfc_error ("Pointer assignment target is neither TARGET " diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 45f8ef1b372..cc4efe70f9e 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-01-21 Tobias Burnus + + PR fortran/47377 + * gfortran.dg/pointer_target_4.f90: New. + 2011-01-20 Michael Meissner PR target/47251 diff --git a/gcc/testsuite/gfortran.dg/pointer_target_4.f90 b/gcc/testsuite/gfortran.dg/pointer_target_4.f90 new file mode 100644 index 00000000000..cda3453d9d8 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pointer_target_4.f90 @@ -0,0 +1,15 @@ +! { dg-do compile } +! +! PR fortran/47377 +! +! Contributed by +! +program testgferr + real, pointer :: y + y => f() ! { dg-error "must deliver a pointer result" } +contains + function f() + real :: f + f = 5 + end function f +end program testgferr -- 2.30.2