From 7fc0c668f2aceb8582d74db1ad2528e2bba8a921 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Wed, 20 Feb 2019 17:03:47 +0000 Subject: [PATCH] Fix a illegal memory access fault when parsing a corrupt MIPS option section using readelf. PR 24243 * readelf.c (process_mips_specific): Check for an options section that is too small to even contain a single option. --- binutils/ChangeLog | 3 +++ binutils/readelf.c | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 1ae5044fd34..1d5561054ac 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -2,6 +2,9 @@ PR 24242 * readelf.c (print_ia64_vms_note): Harden against corrupt notes. + PR 24243 + * readelf.c (process_mips_specific): Check for an options section + that is too small to even contain a single option. 2019-02-20 Alan Modra diff --git a/binutils/readelf.c b/binutils/readelf.c index 54d165e6099..20ebacc9cbd 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -16187,6 +16187,12 @@ process_mips_specific (Filedata * filedata) error (_("No MIPS_OPTIONS header found\n")); return FALSE; } + /* PR 24243 */ + if (sect->sh_size < sizeof (* eopt)) + { + error (_("The MIPS options section is too small.\n")); + return FALSE; + } eopt = (Elf_External_Options *) get_data (NULL, filedata, options_offset, 1, sect->sh_size, _("options")); -- 2.30.2