From 80047cfc27459d4d31fe275ddd02231d812ddb61 Mon Sep 17 00:00:00 2001 From: Philippe Waroquiers Date: Sat, 9 Feb 2019 11:43:35 +0100 Subject: [PATCH] Fix gdb.multi/multi-arch-exec.exp blocking under high load/slow gdb When running multi-arch-exec.exp under valgrind, the test succeeds when the machine is not loaded, but blocks when the machine is highly loaded (e.g. when running the testsuite with valgrind with -j X where X is one more than the nr of available cores). The problem is that the hello program dies too early due to the alarm (30). So, increase the alarm timer. Note that this does not make the test take longer (it takes about 3.5 seconds on my system). As I understand, the alarm is just there to avoid hello staying there forever in case of another problem. 2019-03-28 Philippe Waroquiers * gdb.multi/hello.c (main): Increase alarm timer. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.multi/hello.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 9f0065b016a..4a4a87cf1cc 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-03-28 Philippe Waroquiers + + * gdb.multi/hello.c (main): Increase alarm timer. + 2019-03-28 Sandra Loosemore * gdb.threads/watchpoint-fork.exp (test): Use large timeout diff --git a/gdb/testsuite/gdb.multi/hello.c b/gdb/testsuite/gdb.multi/hello.c index c079a18edd8..b742a7345f0 100644 --- a/gdb/testsuite/gdb.multi/hello.c +++ b/gdb/testsuite/gdb.multi/hello.c @@ -48,7 +48,7 @@ main() { int tmpx; - alarm (30); + alarm (240); bar(); tmpx = hello(glob); -- 2.30.2