From 817411044a689cc26a5444a108f4f66c6484f632 Mon Sep 17 00:00:00 2001 From: Xiretza Date: Fri, 19 Jun 2020 11:46:06 +0200 Subject: [PATCH] Add missing [[noreturn]] to log_file_error() Previously this was tagged only with YS_ATTRIBUTE(noreturn), but not YS_NORETURN, so it got lost in #2173, resulting in warnings in frontends/ast/simplify.cc: frontends/ast/simplify.cc:267:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ frontends/ast/simplify.cc:379:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn] } ^ --- kernel/log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/log.h b/kernel/log.h index 9a6c2a8e6..501d20c09 100644 --- a/kernel/log.h +++ b/kernel/log.h @@ -152,7 +152,7 @@ void log_file_info(const std::string &filename, int lineno, const char *format, void log_warning_noprefix(const char *format, ...) YS_ATTRIBUTE(format(printf, 1, 2)); [[noreturn]] void log_error(const char *format, ...) YS_ATTRIBUTE(format(printf, 1, 2)); -void log_file_error(const string &filename, int lineno, const char *format, ...) YS_ATTRIBUTE(format(printf, 3, 4)); +[[noreturn]] void log_file_error(const string &filename, int lineno, const char *format, ...) YS_ATTRIBUTE(format(printf, 3, 4)); [[noreturn]] void log_cmd_error(const char *format, ...) YS_ATTRIBUTE(format(printf, 1, 2)); #ifndef NDEBUG -- 2.30.2