From 81b11bf0934d5387bd3741b6268501df3973a6a7 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Wed, 14 May 2014 01:04:02 -0700 Subject: [PATCH] i965/fs: Actually free program data on the error path. We throw away the data generated during compilation on the success path, so we really ought to on the failure path as well. The caller has no access to it anyway, so it's purely leaked. Signed-off-by: Kenneth Graunke Reviewed-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_wm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c index 5242715603a..059d848ff13 100644 --- a/src/mesa/drivers/dri/i965/brw_wm.c +++ b/src/mesa/drivers/dri/i965/brw_wm.c @@ -181,8 +181,10 @@ bool do_wm_prog(struct brw_context *brw, &fp->program); program = brw_wm_fs_emit(brw, c, &fp->program, prog, &program_size); - if (program == NULL) + if (program == NULL) { + ralloc_free(c); return false; + } if (c->prog_data.total_scratch) { brw_get_scratch_bo(brw, &brw->wm.base.scratch_bo, -- 2.30.2