From 81cead6f5e9b765788483ad66f490f7540264eba Mon Sep 17 00:00:00 2001 From: Trevor Saunders Date: Mon, 23 May 2016 07:42:14 -0400 Subject: [PATCH] metag: make an array's type unsigned char[] It contains values between 128 and 256 which fit in an unsigned char, but not a signed char, so we should explicitly use unsigned char to not rely on how these values are converted to signed char. gas/ChangeLog: 2016-05-26 Trevor Saunders * config/tc-metag.c (metag_handle_align): Make the type of noop unsigned char. --- gas/ChangeLog | 5 +++++ gas/config/tc-metag.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index ae4de64f90f..b21e332d80d 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2016-05-26 Trevor Saunders + + * config/tc-metag.c (metag_handle_align): Make the type of noop + unsigned char. + 2016-05-26 Trevor Saunders * config/tc-rx.c (md_convert_frag): Make the type of reloc_type diff --git a/gas/config/tc-metag.c b/gas/config/tc-metag.c index 1c459241a6a..a6c71526ce8 100644 --- a/gas/config/tc-metag.c +++ b/gas/config/tc-metag.c @@ -6847,7 +6847,7 @@ md_convert_frag (bfd * abfd ATTRIBUTE_UNUSED, segT sec ATTRIBUTE_UNUSED, void metag_handle_align (fragS * fragP) { - static char const noop[4] = { 0xfe, 0xff, 0xff, 0xa0 }; + static unsigned char const noop[4] = { 0xfe, 0xff, 0xff, 0xa0 }; int bytes, fix; char *p; -- 2.30.2