From 82836c928ffc6aaa9e594ba69af5f446bdc95bf4 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 7 Jun 2020 08:22:46 -0600 Subject: [PATCH] Remove unused parameter from generic_val_print_float generic_val_print_float has an "embedded_offset" parameter, but it can only ever be 0. I believe it is a leftover from the val_print removal. This patch removes this parameter. gdb/ChangeLog 2020-06-07 Tom Tromey * valprint.c (generic_val_print_float): Remove "embedded_offset" parameter. (generic_value_print): Update. --- gdb/ChangeLog | 6 ++++++ gdb/valprint.c | 11 +++-------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5cd74e6c31b..02880536568 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2020-06-07 Tom Tromey + + * valprint.c (generic_val_print_float): Remove "embedded_offset" + parameter. + (generic_value_print): Update. + 2020-06-05 Andrew Burgess Revert commit 982a38f60b0. diff --git a/gdb/valprint.c b/gdb/valprint.c index d678ad3091a..ca7dab680ae 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -781,19 +781,15 @@ generic_value_print_char (struct value *value, struct ui_file *stream, /* generic_val_print helper for TYPE_CODE_FLT and TYPE_CODE_DECFLOAT. */ static void -generic_val_print_float (struct type *type, - int embedded_offset, struct ui_file *stream, +generic_val_print_float (struct type *type, struct ui_file *stream, struct value *original_value, const struct value_print_options *options) { - struct gdbarch *gdbarch = get_type_arch (type); - int unit_size = gdbarch_addressable_memory_unit_size (gdbarch); - gdb_assert (!options->format); const gdb_byte *valaddr = value_contents_for_printing (original_value); - print_floating (valaddr + embedded_offset * unit_size, type, stream); + print_floating (valaddr, type, stream); } /* generic_value_print helper for TYPE_CODE_COMPLEX. */ @@ -896,8 +892,7 @@ generic_value_print (struct value *val, struct ui_file *stream, int recurse, if (options->format) value_print_scalar_formatted (val, options, 0, stream); else - generic_val_print_float (type, 0, stream, - val, options); + generic_val_print_float (type, stream, val, options); break; case TYPE_CODE_VOID: -- 2.30.2