From 8392fa22d69113602407281cbb364f29557c39b1 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 13 Apr 2016 10:47:29 -0400 Subject: [PATCH] Fix and improve comment in gdb_remote_download This patch fixes the current comment in gdb_remote_download, which is false (the "except if that's already where it is" part). It also improves it, by explaining why pass TOFILE through standard_output_file, even it is an absolute path. gdb/testsuite/ChangeLog: * lib/gdb.exp (gdb_remote_download): Fix and extend comment. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/lib/gdb.exp | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index ef3e66d0f35..47e8ae39bc2 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2016-04-13 Simon Marchi + + * lib/gdb.exp (gdb_remote_download): Fix and extend comment. + 2016-04-13 Simon Marchi * boards/gdbserver-base.exp (${board}_download): Copy source file to diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 1ef6a9693ed..0d8a3b060fa 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -4211,8 +4211,13 @@ proc gdb_remote_download {dest fromfile {tofile {}}} { return $destname } else { - # When the DEST is local, we copy the file to the test directory - # (where the executable is), except if that's already where it is. + # When the DEST is local, we copy the file to the test directory (where + # the executable is). + # + # Note that we pass TOFILE through standard_output_file, regardless of + # whether it is absolute or relative, because we don't want the tests + # to be able to write outside their standard output directory. + set tofile [standard_output_file $tofile] file copy -force $fromfile $tofile -- 2.30.2