From 8420d4c169c78bc54d6bc6ef7a7e7c2be50052df Mon Sep 17 00:00:00 2001 From: Baruch Siach Date: Thu, 3 Jul 2014 19:32:58 +0300 Subject: [PATCH] toolchain/helpers.mk: don't discard check_arm_abi stderr Since we only need to know whether the compiler runs successfully, and stderr is empty for the success case, there is no need to redirect stderr to /dev/null. Moreover, stderr output of the failing case reveals valuable information on the real failure reason. Cc: Thomas Petazzoni Signed-off-by: Baruch Siach Acked-by: Thomas Petazzoni Signed-off-by: Peter Korsgaard --- toolchain/helpers.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk index 81e02b7132..c8c645a311 100644 --- a/toolchain/helpers.mk +++ b/toolchain/helpers.mk @@ -297,7 +297,7 @@ check_arm_abi = \ echo "External toolchain uses the unsuported OABI" ; \ exit 1 ; \ fi ; \ - if ! echo 'int main(void) {}' | $${__CROSS_CC} -x c -o /dev/null - 2>/dev/null; then \ + if ! echo 'int main(void) {}' | $${__CROSS_CC} -x c -o /dev/null - ; then \ abistr_$(BR2_ARM_EABI)='EABI'; \ abistr_$(BR2_ARM_EABIHF)='EABIhf'; \ echo "Incorrect ABI setting: $${abistr_y} selected, but toolchain is incompatible"; \ -- 2.30.2