From 8473b4472dce9ce87aaad35ff8e975e1487f914e Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sun, 9 Apr 2017 23:14:36 -0400 Subject: [PATCH] windows-nat.c: Fix bad initialization of ptid MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When trying to build for x86_64-w64-mingw32: /home/simark/src/binutils-gdb/gdb/windows-nat.c: In function ‘void windows_detach(target_ops*, const char*, int)’: /home/simark/src/binutils-gdb/gdb/windows-nat.c:1915:20: error: converting to ‘ptid_t’ from initializer list would use explicit constructor ‘constexpr ptid_t::ptid_t(int, long int, long int)’ ptid_t ptid = {-1}; ^ Fixed by initializing ptid with the minus_one_ptid variable. gdb/ChangeLog: * windows-nat.c (windows_detach): Initialize ptid with minus_one_ptid. --- gdb/ChangeLog | 5 +++++ gdb/windows-nat.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 01c4c70b53f..f08f5201d1c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-04-09 Simon Marchi + + * windows-nat.c (windows_detach): Initialize ptid with + minus_one_ptid. + 2017-04-07 Simon Marchi * unittests/ptid-selftests.c: Fix erroneous assert messages. diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index ec0ae0691cc..21b5ebefd8d 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1912,7 +1912,7 @@ windows_detach (struct target_ops *ops, const char *args, int from_tty) { int detached = 1; - ptid_t ptid = {-1}; + ptid_t ptid = minus_one_ptid; windows_resume (ops, ptid, 0, GDB_SIGNAL_0); if (!DebugActiveProcessStop (current_event.dwProcessId)) -- 2.30.2