From 8476dc92e4d8f8e8ebcdbaf0080b70876dfcfb27 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 16 Jan 2014 11:46:23 -0700 Subject: [PATCH] fix buglet in nto-procfs.c I happened to notice that nto-procfs.c defines procfs_remove_hw_breakpoint but never uses it. This caused it not to be updated by my target-method-updating script. This patch fixes the function and installs it properly. I have no way to test this, however. 2014-02-19 Tom Tromey * nto-procfs.c (procfs_remove_hw_breakpoint): Add 'self' argument. (init_procfs_ops): Correctly set to_remove_hw_breakpoint. --- gdb/ChangeLog | 6 ++++++ gdb/nto-procfs.c | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ff6188b0347..c75ca0d157c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-02-19 Tom Tromey + + * nto-procfs.c (procfs_remove_hw_breakpoint): Add 'self' + argument. + (init_procfs_ops): Correctly set to_remove_hw_breakpoint. + 2014-02-19 Tom Tromey * record-btrace.c (record_btrace_decr_pc_after_break): Delegate diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c index 1b2b2ff6e62..d0bdc90b8d8 100644 --- a/gdb/nto-procfs.c +++ b/gdb/nto-procfs.c @@ -947,7 +947,8 @@ procfs_insert_hw_breakpoint (struct target_ops *self, struct gdbarch *gdbarch, } static int -procfs_remove_hw_breakpoint (struct gdbarch *gdbarch, +procfs_remove_hw_breakpoint (struct target_ops *self, + struct gdbarch *gdbarch, struct bp_target_info *bp_tgt) { return procfs_breakpoint (bp_tgt->placed_address, @@ -1402,7 +1403,7 @@ init_procfs_ops (void) procfs_ops.to_remove_breakpoint = procfs_remove_breakpoint; procfs_ops.to_can_use_hw_breakpoint = procfs_can_use_hw_breakpoint; procfs_ops.to_insert_hw_breakpoint = procfs_insert_hw_breakpoint; - procfs_ops.to_remove_hw_breakpoint = procfs_remove_breakpoint; + procfs_ops.to_remove_hw_breakpoint = procfs_remove_hw_breakpoint; procfs_ops.to_insert_watchpoint = procfs_insert_hw_watchpoint; procfs_ops.to_remove_watchpoint = procfs_remove_hw_watchpoint; procfs_ops.to_stopped_by_watchpoint = procfs_stopped_by_watchpoint; -- 2.30.2