From 848ac659685fba46ce8816400db705f60c8040f7 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Thu, 11 Aug 2016 16:04:59 +0100 Subject: [PATCH] objcopy: Close some memory leaks in error paths Closes some memory leaks within objcopy for error paths. binutils/ChangeLog: * objcopy.c (copy_section): Add extra calls to free for error paths. --- binutils/ChangeLog | 5 +++++ binutils/objcopy.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index f1e1f9bd3f2..09f76b92212 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2016-11-04 Andrew Burgess + + * objcopy.c (copy_section): Add extra calls to free for error + paths. + 2016-11-04 Tom Tromey * dwarf-mode.el (dwarf-browse): Set default-directory. Bump diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 1821c0ce1be..d40cfcb2bb6 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -3375,6 +3375,7 @@ copy_section (bfd *ibfd, sec_ptr isection, void *obfdarg) { status = 1; bfd_nonfatal_message (NULL, ibfd, isection, NULL); + free (memhunk); return; } @@ -3428,6 +3429,7 @@ copy_section (bfd *ibfd, sec_ptr isection, void *obfdarg) { status = 1; bfd_nonfatal_message (NULL, obfd, osection, NULL); + free (memhunk); return; } free (memhunk); @@ -3449,6 +3451,7 @@ copy_section (bfd *ibfd, sec_ptr isection, void *obfdarg) { status = 1; bfd_nonfatal_message (NULL, obfd, osection, NULL); + free (memhunk); return; } free (memhunk); -- 2.30.2