From 85113c4d0507f91dd773b555b8e3f75423275010 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Wed, 15 Aug 2018 15:28:43 +0200 Subject: [PATCH] radv: fix memory leaks in radv_load_meta_pipeline() Reported by Coverity. Fixes: fbcd167314 ("radv: Add on-demand compilation of built-in shaders.") Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c index ccdcb9ceb07..b8d0a7cfc70 100644 --- a/src/amd/vulkan/radv_meta.c +++ b/src/amd/vulkan/radv_meta.c @@ -263,6 +263,7 @@ radv_load_meta_pipeline(struct radv_device *device) char path[PATH_MAX + 1]; struct stat st; void *data = NULL; + bool ret = false; if (!radv_builtin_cache_path(path)) return false; @@ -278,11 +279,11 @@ radv_load_meta_pipeline(struct radv_device *device) if(read(fd, data, st.st_size) == -1) goto fail; - return radv_pipeline_cache_load(&device->meta_state.cache, data, st.st_size); + ret = radv_pipeline_cache_load(&device->meta_state.cache, data, st.st_size); fail: free(data); close(fd); - return false; + return ret; } static void -- 2.30.2