From 852a7bcf923af424de8df1ddbeb462d52de8383b Mon Sep 17 00:00:00 2001 From: Andreas Hansson Date: Mon, 7 Jan 2013 13:05:35 -0500 Subject: [PATCH] mem: Add sanity check to packet queue size This patch adds a basic check to ensure that the packet queue does not grow absurdly large. The queue should only be used to store packets that were delayed due to blocking from the neighbouring port, and not for actual storage. Thus, a limit of 100 has been chosen for now (which is already quite substantial). --- src/mem/packet_queue.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/mem/packet_queue.cc b/src/mem/packet_queue.cc index 8030cb38f..e60e77453 100644 --- a/src/mem/packet_queue.cc +++ b/src/mem/packet_queue.cc @@ -113,6 +113,13 @@ PacketQueue::schedSendTiming(PacketPtr pkt, Tick when, bool send_as_snoop) // express snoops should never be queued assert(!pkt->isExpressSnoop()); + // add a very basic sanity check on the port to ensure the + // invisible buffer is not growing beyond reasonable limits + if (transmitList.size() > 100) { + panic("Packet queue %s has grown beyond 100 packets\n", + name()); + } + // nothing on the list, or earlier than current front element, // schedule an event if (transmitList.empty() || when < transmitList.front().tick) { -- 2.30.2