From 854ed47f3e1501e4cc87bf9f19c6d4a1ad2bab08 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Nicolai=20H=C3=A4hnle?= Date: Thu, 4 May 2017 15:20:48 +0200 Subject: [PATCH] radeonsi: mark fast-cleared textures as compressed when dirtying MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There are a bunch of piglit fast clear tests that regressed on SI, for example ./bin/ext_framebuffer_multisample-fast-clear single-sample. The problem is that a texture is bound as a framebuffer, cleared, and then rendered from in a loop that loops through different clear colors. The texture is never rebound during all this, so the change to tex->dirty_level_mask during fast clear was not taken into account when checking for compressed textures. I have considered simply reverting the problematic commit. However, I think this solution is better. It does require looping through all bound textures after a fast clear, but the alternative would require visiting more textures needless on every draw. Draws are much more common than clears. Note that the rendering feedback loop rules do not apply here, because the framebuffer binding is changed between the glClear and the draw that samples from the texture that was cleared. Fixes: bdd644976952 ("radeonsi: don't mark non-dirty textures with CMASK as compressed") Cc: 17.1 Reviewed-by: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 8110ec1484c..57e3960268f 100644 --- a/src/gallium/drivers/radeon/r600_texture.c +++ b/src/gallium/drivers/radeon/r600_texture.c @@ -2720,8 +2720,15 @@ void evergreen_do_fast_color_clear(struct r600_common_context *rctx, vi_dcc_clear_level(rctx, tex, 0, reset_value); - if (clear_words_needed) - tex->dirty_level_mask |= 1 << fb->cbufs[i]->u.tex.level; + unsigned level_bit = 1 << fb->cbufs[i]->u.tex.level; + if (clear_words_needed) { + bool need_compressed_update = !tex->dirty_level_mask; + + tex->dirty_level_mask |= level_bit; + + if (need_compressed_update) + p_atomic_inc(&rctx->screen->compressed_colortex_counter); + } tex->separate_dcc_dirty = true; } else { /* 128-bit formats are unusupported */ @@ -2744,7 +2751,12 @@ void evergreen_do_fast_color_clear(struct r600_common_context *rctx, tex->cmask.offset, tex->cmask.size, 0, R600_COHERENCY_CB_META); + bool need_compressed_update = !tex->dirty_level_mask; + tex->dirty_level_mask |= 1 << fb->cbufs[i]->u.tex.level; + + if (need_compressed_update) + p_atomic_inc(&rctx->screen->compressed_colortex_counter); } /* We can change the micro tile mode before a full clear. */ -- 2.30.2