From 8585103f053ef26a5939ec7c3a08ad77f70d2c3c Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Tue, 11 Apr 2017 19:19:56 +0200 Subject: [PATCH] re PR rtl-optimization/80385 (Segfault in commutative_operand_precedence() rtlanal.c:3373) PR rtl-optimization/80385 * simplify-rtx.c (simplify_unary_operation_1): Don't transform (not (neg X)) into (plus X -1) for complex or non-integral modes. * g++.dg/opt/pr80385.C: New test. From-SVN: r246850 --- gcc/ChangeLog | 4 ++++ gcc/simplify-rtx.c | 6 ++++-- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/opt/pr80385.C | 14 ++++++++++++++ 4 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/opt/pr80385.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 900e58ce58e..ea434f6e280 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2017-04-11 Jakub Jelinek + PR rtl-optimization/80385 + * simplify-rtx.c (simplify_unary_operation_1): Don't transform + (not (neg X)) into (plus X -1) for complex or non-integral modes. + PR libgomp/80394 * omp-low.c (scan_omp_task): Don't optimize away empty tasks if they have any depend clauses. diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c index cff7e4d3e3f..4bbbe2354e3 100644 --- a/gcc/simplify-rtx.c +++ b/gcc/simplify-rtx.c @@ -932,8 +932,10 @@ simplify_unary_operation_1 (enum rtx_code code, machine_mode mode, rtx op) && XEXP (op, 1) == constm1_rtx) return simplify_gen_unary (NEG, mode, XEXP (op, 0), mode); - /* Similarly, (not (neg X)) is (plus X -1). */ - if (GET_CODE (op) == NEG) + /* Similarly, (not (neg X)) is (plus X -1). Only do this for + modes that have CONSTM1_RTX, i.e. MODE_INT, MODE_PARTIAL_INT + and MODE_VECTOR_INT. */ + if (GET_CODE (op) == NEG && CONSTM1_RTX (mode)) return simplify_gen_binary (PLUS, mode, XEXP (op, 0), CONSTM1_RTX (mode)); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 584813f361b..a0182888174 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-04-11 Jakub Jelinek + + PR rtl-optimization/80385 + * g++.dg/opt/pr80385.C: New test. + 2017-04-11 Martin Liska PR ipa/80212 diff --git a/gcc/testsuite/g++.dg/opt/pr80385.C b/gcc/testsuite/g++.dg/opt/pr80385.C new file mode 100644 index 00000000000..f18abc941f3 --- /dev/null +++ b/gcc/testsuite/g++.dg/opt/pr80385.C @@ -0,0 +1,14 @@ +// PR rtl-optimization/80385 +// { dg-do compile { target { i?86-*-* x86_64-*-* } } } +// { dg-options "-Ofast -msse2" } + +#include + +__m128 a, e; +struct A { __m128 b; A (); A (__m128 x) : b(x) {} }; +A operator+ (A, A); +A operator- (A) { __m128 c = -a; return c; } +A foo (A x) { __m128 d = x.b; return _mm_andnot_ps (d, e); } +struct B { A n[1]; }; +void bar (B x) { A f = foo (x.n[0]); A g = f + A (); } +void baz () { B h; B i; A j; i.n[0] = -j; h = i; B k = h; bar (k); } -- 2.30.2