From 85e7a59cf0fa0faf4ba6ce61207a863d8840c453 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Wed, 11 Sep 2019 13:54:42 -0700 Subject: [PATCH] mem: Delete the MessageReq and MessageResp memory commands. Now that Message*Port is gone, there are no users of these two memory commands. They can now be deleted, simplifying the memory system slightly. Change-Id: If157dade4a3fb2610756c2ee81dc0c3fac670a26 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/20824 Reviewed-by: Gabe Black Reviewed-by: Jason Lowe-Power Maintainer: Gabe Black Tested-by: kokoro --- src/mem/packet.cc | 7 ++----- src/mem/packet.hh | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/mem/packet.cc b/src/mem/packet.cc index 1d1b5b8d7..551ccd8be 100644 --- a/src/mem/packet.cc +++ b/src/mem/packet.cc @@ -180,11 +180,8 @@ MemCmd::commandInfo[] = /* SwapResp -- for Swap ldstub type operations */ { SET4(IsRead, IsWrite, IsResponse, HasData), InvalidCmd, "SwapResp" }, - /* IntReq -- for interrupts */ - { SET4(IsWrite, IsRequest, NeedsResponse, HasData), - MessageResp, "MessageReq" }, - /* IntResp -- for interrupts */ - { SET2(IsWrite, IsResponse), InvalidCmd, "MessageResp" }, + { 0, InvalidCmd, "Deprecated_MessageReq" }, + { 0, InvalidCmd, "Deprecated_MessageResp" }, /* MemFenceReq -- for synchronization requests */ {SET2(IsRequest, NeedsResponse), MemFenceResp, "MemFenceReq"}, /* MemFenceResp -- for synchronization responses */ diff --git a/src/mem/packet.hh b/src/mem/packet.hh index 130cc41ad..407172f98 100644 --- a/src/mem/packet.hh +++ b/src/mem/packet.hh @@ -115,9 +115,8 @@ class MemCmd StoreCondResp, SwapReq, SwapResp, - MessageReq, - MessageResp, - MemFenceReq, + // MessageReq and MessageResp are deprecated. + MemFenceReq = SwapResp + 3, MemFenceResp, CleanSharedReq, CleanSharedResp, -- 2.30.2