From 8610c6e21e45ff68c8c3e8a8747768c34daaf560 Mon Sep 17 00:00:00 2001 From: Luke Kenneth Casson Leighton Date: Tue, 22 Feb 2022 12:56:59 +0000 Subject: [PATCH] remove continue/skip and add comment that all control pins have to be requested "xdr:4" --- gram/phy/ecp5ddrphy.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gram/phy/ecp5ddrphy.py b/gram/phy/ecp5ddrphy.py index 17098b1..336b063 100644 --- a/gram/phy/ecp5ddrphy.py +++ b/gram/phy/ecp5ddrphy.py @@ -235,7 +235,9 @@ class ECP5DDRPHY(Peripheral, Elaboratable): self.pads.ba.o3[i].eq(dfi.phases[1].bank[i]), ] - # Control pins + # Control pins: all of thees have to be declared "xdr 4" when + # requesting the resource: + # ddr_pins = platform.request("ddr3", 0, xdr={"clk":4, "odt":4, ... }) controls = ["ras", "cas", "we", "clk_en", "odt"] if hasattr(self.pads, "reset"): controls.append("reset") @@ -244,8 +246,6 @@ class ECP5DDRPHY(Peripheral, Elaboratable): for name in controls: print ("clock", name, getattr(self.pads, name)) pad = getattr(self.pads, name) - if not hasattr(pad, "o_clk"): - continue m.d.comb += [ pad.o_clk.eq(ClockSignal("dramsync")), pad.o_fclk.eq(ClockSignal("sync2x")), -- 2.30.2