From 8626fe101ded3e08d0f97c5e1ce74f3165783f76 Mon Sep 17 00:00:00 2001 From: "Daniel R. Carvalho" Date: Sat, 27 Jun 2020 20:51:03 +0200 Subject: [PATCH] mem-cache: Explicitly define threshold of BDI's sub-compressors Allow all sub-compressors of BDI to be successful as long as they are able to compress. Then, BDI's actual size threshold acts as the cutting point. This situation arises on any multi compressor; yet, generalizing this assumption might be too bold. Change-Id: Iec5057d16d4a7ba5fb573133a30ea10869bd67e0 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33386 Reviewed-by: Nikos Nikoleris Maintainer: Nikos Nikoleris Tested-by: kokoro --- src/mem/cache/compressors/Compressors.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mem/cache/compressors/Compressors.py b/src/mem/cache/compressors/Compressors.py index 9fa06f210..2497e82e0 100644 --- a/src/mem/cache/compressors/Compressors.py +++ b/src/mem/cache/compressors/Compressors.py @@ -148,6 +148,13 @@ class ZeroCompressor(BaseDictionaryCompressor): class BDI(MultiCompressor): encoding_in_tags=True - compressors = [ZeroCompressor(), RepeatedQwordsCompressor(), - Base64Delta8(), Base64Delta16(), Base64Delta32(), Base32Delta8(), - Base32Delta16(), Base16Delta8()] + compressors = [ + ZeroCompressor(size_threshold_percentage=99), + RepeatedQwordsCompressor(size_threshold_percentage=99), + Base64Delta8(size_threshold_percentage=99), + Base64Delta16(size_threshold_percentage=99), + Base64Delta32(size_threshold_percentage=99), + Base32Delta8(size_threshold_percentage=99), + Base32Delta16(size_threshold_percentage=99), + Base16Delta8(size_threshold_percentage=99), + ] -- 2.30.2