From 877c00c653ac782f8867a3fee24f16707b1d568c Mon Sep 17 00:00:00 2001 From: Jakob Sinclair Date: Wed, 18 May 2016 19:48:29 +0200 Subject: [PATCH] gallium/radeon: fixed division by zero MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Coverity is getting a false positive that a division by zero can occur here. This change will silence the Coverity warnings as a division by zero cannot occur in this case. Signed-off-by: Jakob Sinclair Reviewed-by: Nicolai Hähnle Signed-off-by: Marek Olšák --- src/gallium/drivers/radeon/r600_test_dma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_test_dma.c b/src/gallium/drivers/radeon/r600_test_dma.c index c203b4d9a2e..1e60f6affa7 100644 --- a/src/gallium/drivers/radeon/r600_test_dma.c +++ b/src/gallium/drivers/radeon/r600_test_dma.c @@ -345,6 +345,9 @@ void r600_test_dma(struct r600_common_screen *rscreen) dstx = rand() % (tdst.width0 - width + 1) & ~0x7; dsty = rand() % (tdst.height0 - height + 1) & ~0x7; } else { + /* just make sure that it doesn't divide by zero */ + assert(max_width > 0 && max_height > 0); + width = (rand() % max_width) + 1; height = (rand() % max_height) + 1; -- 2.30.2