From 880d97770b63eb722d53b3a0ae2f03deae0c9c72 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Thu, 2 Apr 2020 17:12:49 +0200 Subject: [PATCH] [gdb/testsuite] Don't use O2 for inlining in break-inline-psymtab.exp In test-case gdb.dwarf2/break-inline-psymtab.exp we use O2 to enable inlining of bar into foo in break-inline-psymtab-2.c. Instead, enforce inlining using __attribute__((always_inline)), to avoid any optimization-related test issues. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-04-02 Tom de Vries * gdb.dwarf2/break-inline-psymtab-2.c (bar): Add __attribute__((always_inline)). * gdb.dwarf2/break-inline-psymtab.exp: Don't use -O2. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c | 2 +- gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp | 3 +-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 99813054d5d..d662727ac5c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2020-04-02 Tom de Vries + + * gdb.dwarf2/break-inline-psymtab-2.c (bar): Add + __attribute__((always_inline)). + * gdb.dwarf2/break-inline-psymtab.exp: Don't use -O2. + 2020-04-02 Tom de Vries * lib/gdbserver-support.exp (gdbserver_exit): Factor out of ... diff --git a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c index 38c69336f20..b7fe485b3aa 100644 --- a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c +++ b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab-2.c @@ -19,7 +19,7 @@ extern int foo (void); int a; -static inline int +static inline int __attribute__((always_inline)) bar (void) { a = 2; diff --git a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp index adbe8620aa7..344d7da0d54 100644 --- a/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp +++ b/gdb/testsuite/gdb.dwarf2/break-inline-psymtab.exp @@ -16,8 +16,7 @@ standard_testfile break-inline-psymtab.c break-inline-psymtab-2.c set sources [list $srcfile $srcfile2] -set opts {debug optimize=-O2} -if { [prepare_for_testing "failed to prepare" ${testfile} $sources $opts] } { +if { [prepare_for_testing "failed to prepare" ${testfile} $sources] } { return -1 } -- 2.30.2