From 8828d8620249e09d98139788f6be8535cfe57728 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Sun, 12 Sep 1999 02:59:54 +0000 Subject: [PATCH] 1999-09-11 Donn Terry * config/obj-coff.c (coff_frob_symbol): Prohibit weak common symbols. --- gas/ChangeLog | 3 +++ gas/config/obj-coff.c | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/gas/ChangeLog b/gas/ChangeLog index a0b15a644c0..a93c1dfb415 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -5,6 +5,9 @@ 1999-09-11 Donn Terry + * config/obj-coff.c (coff_frob_symbol): Prohibit weak common + symbols. + * config/obj-coff.c (obj_coff_endef): Don't merge labels, or symbols which do not have a constant value, or tags with non-tags. Remove the symbol from the list before adding it at the diff --git a/gas/config/obj-coff.c b/gas/config/obj-coff.c index 4207ea0fa29..86e07667479 100644 --- a/gas/config/obj-coff.c +++ b/gas/config/obj-coff.c @@ -1169,6 +1169,11 @@ coff_frob_symbol (symp, punt) /* more ... */ } + /* Double check weak symbols. */ + if (S_IS_WEAK (symp) && S_IS_COMMON (symp)) + as_bad (_("Symbol `%s' can not be both weak and common"), + S_GET_NAME (symp)); + if (SF_GET_TAG (symp)) last_tagP = symp; else if (S_GET_STORAGE_CLASS (symp) == C_EOS) -- 2.30.2