From 8864c2ea24e274accdd0562d6854930a7130a325 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Sun, 30 Aug 2020 01:24:50 -0700 Subject: [PATCH] mips,cpu: Eliminate the unused IsIndexed StaticInst flag. It's set by some MIPS instructions, but does not have an accessor in StaticInst and is not used by anything. Change-Id: I3466f7d2723fb1b0ac195064867e3840e3a8f21b Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33735 Reviewed-by: Bobby R. Bruce Reviewed-by: Jason Lowe-Power Maintainer: Gabe Black Tested-by: kokoro --- src/arch/mips/isa/formats/mem.isa | 6 ++---- src/cpu/StaticInstFlags.py | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/arch/mips/isa/formats/mem.isa b/src/arch/mips/isa/formats/mem.isa index 491dd0cc1..c5fd6f89e 100644 --- a/src/arch/mips/isa/formats/mem.isa +++ b/src/arch/mips/isa/formats/mem.isa @@ -458,7 +458,6 @@ def format StoreMemory(memacc_code, ea_code = {{ EA = Rs + disp; }}, def format LoadIndexedMemory(memacc_code, ea_code = {{ EA = Rs + Rt; }}, mem_flags = [], inst_flags = []) {{ - inst_flags += ['IsIndexed'] (header_output, decoder_output, decode_block, exec_output) = \ LoadStoreBase(name, Name, ea_code, memacc_code, mem_flags, inst_flags, decode_template = ImmNopCheckDecode, @@ -467,7 +466,6 @@ def format LoadIndexedMemory(memacc_code, ea_code = {{ EA = Rs + Rt; }}, def format StoreIndexedMemory(memacc_code, ea_code = {{ EA = Rs + Rt; }}, mem_flags = [], inst_flags = []) {{ - inst_flags += ['IsIndexed'] (header_output, decoder_output, decode_block, exec_output) = \ LoadStoreBase(name, Name, ea_code, memacc_code, mem_flags, inst_flags, exec_template_base = 'Store') @@ -475,7 +473,7 @@ def format StoreIndexedMemory(memacc_code, ea_code = {{ EA = Rs + Rt; }}, def format LoadFPIndexedMemory(memacc_code, ea_code = {{ EA = Rs + Rt; }}, mem_flags = [], inst_flags = []) {{ - inst_flags += ['IsIndexed', 'IsFloating'] + inst_flags += ['IsFloating'] (header_output, decoder_output, decode_block, exec_output) = \ LoadStoreBase(name, Name, ea_code, memacc_code, mem_flags, inst_flags, decode_template = ImmNopCheckDecode, @@ -484,7 +482,7 @@ def format LoadFPIndexedMemory(memacc_code, ea_code = {{ EA = Rs + Rt; }}, def format StoreFPIndexedMemory(memacc_code, ea_code = {{ EA = Rs + Rt; }}, mem_flags = [], inst_flags = []) {{ - inst_flags += ['IsIndexed', 'IsFloating'] + inst_flags += ['IsFloating'] (header_output, decoder_output, decode_block, exec_output) = \ LoadStoreBase(name, Name, ea_code, memacc_code, mem_flags, inst_flags, exec_template_base = 'Store') diff --git a/src/cpu/StaticInstFlags.py b/src/cpu/StaticInstFlags.py index 8db54430b..cbdfec394 100644 --- a/src/cpu/StaticInstFlags.py +++ b/src/cpu/StaticInstFlags.py @@ -64,8 +64,6 @@ class StaticInstFlags(Enum): 'IsStore', # Writes to memory. 'IsAtomic', # Does atomic RMW to memory. 'IsStoreConditional', # Store conditional instruction. - 'IsIndexed', # Accesses memory with an indexed address - # computation 'IsInstPrefetch', # Instruction-cache prefetch. 'IsDataPrefetch', # Data-cache prefetch. -- 2.30.2