From 89632536fc913518954ea0c4b6d749d898c6a543 Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Thu, 11 Sep 2014 08:12:28 -0400 Subject: [PATCH] re PR c++/58678 (pykde4-4.11.2 link error (devirtualization too trigger happy)) PR c++/58678 * ipa-devirt.c (ipa_devirt): Don't check DECL_COMDAT. From-SVN: r215168 --- gcc/ChangeLog | 5 +++++ gcc/ipa-devirt.c | 3 +-- gcc/testsuite/g++.dg/ipa/devirt-28a.C | 15 +++++++++++++++ 3 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/ipa/devirt-28a.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 014014a8c14..f3bfbe00577 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-09-11 Jason Merrill + + PR c++/58678 + * ipa-devirt.c (ipa_devirt): Don't check DECL_COMDAT. + 2014-09-11 Georg-Johann Lay PR target/63223 diff --git a/gcc/ipa-devirt.c b/gcc/ipa-devirt.c index f98a18e7b8f..948ae237504 100644 --- a/gcc/ipa-devirt.c +++ b/gcc/ipa-devirt.c @@ -3952,8 +3952,7 @@ ipa_devirt (void) /* Don't use an implicitly-declared destructor (c++/58678). */ struct cgraph_node *non_thunk_target = likely_target->function_symbol (); - if (DECL_ARTIFICIAL (non_thunk_target->decl) - && DECL_COMDAT (non_thunk_target->decl)) + if (DECL_ARTIFICIAL (non_thunk_target->decl)) { if (dump_file) fprintf (dump_file, "Target is artificial\n\n"); diff --git a/gcc/testsuite/g++.dg/ipa/devirt-28a.C b/gcc/testsuite/g++.dg/ipa/devirt-28a.C new file mode 100644 index 00000000000..bdd1682022a --- /dev/null +++ b/gcc/testsuite/g++.dg/ipa/devirt-28a.C @@ -0,0 +1,15 @@ +// PR c++/58678 +// { dg-options "-O3 -flto -shared -fPIC -Wl,--no-undefined" } +// { dg-do link { target { gld && fpic } } } + +struct A { + virtual ~A(); +}; +struct B : A { + virtual int m_fn1(); +}; +void fn1(B* b) { + delete b; +} + +int main() {} -- 2.30.2