From 89833eddab9354da5e70fe695159f6860cbb4cd5 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Sat, 10 Nov 2018 00:08:03 -0800 Subject: [PATCH] iris: leave another TODO --- src/gallium/drivers/iris/iris_batch.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/iris/iris_batch.c b/src/gallium/drivers/iris/iris_batch.c index 203ca139f66..1d3a787d365 100644 --- a/src/gallium/drivers/iris/iris_batch.c +++ b/src/gallium/drivers/iris/iris_batch.c @@ -215,6 +215,9 @@ add_exec_bo(struct iris_batch *batch, struct iris_bo *bo) * those first. */ for (int b = 0; b < ARRAY_SIZE(batch->other_batches); b++) { + // XXX: this is bad, we use the same state / instruction buffers for + // both batches, and if both of them are reading some dynamic state, + // we flush all the time. check for writes vs. reads? if (iris_batch_references(batch->other_batches[b], bo)) iris_batch_flush(batch->other_batches[b]); } -- 2.30.2