From 8a4efb366fadfc8c7eff2994af863a169fe38401 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Mon, 8 Mar 2021 18:11:10 +0000 Subject: [PATCH] gdb/testsuite: check the correct Python variable in test While squashing duplicate test names I spotted what looked like a copy & paste error. During this test a Python variable is created, and then we call the type method on that variable. In one case we create a variable and then call the type method on a variable created for a previous test. I can see no reason why this should be what we want, it doesn't line up with the comments in the test script, so I've updated the test. Note, the expected result doesn't change, just the command issued (the test relates to stripping typedefs). gdb/testsuite/ChangeLog: * gdb.python/lib-types.exp: Update the test to check the correct python variable. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.python/lib-types.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1a3d58009c7..23135be25d1 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2021-03-12 Andrew Burgess + + * gdb.python/lib-types.exp: Update the test to check the correct + python variable. + 2021-03-12 Andrew Burgess * gdb.python/py-explore-cc.exp: Extend test names to make them diff --git a/gdb/testsuite/gdb.python/lib-types.exp b/gdb/testsuite/gdb.python/lib-types.exp index 6376dc94e85..fbc74990f59 100644 --- a/gdb/testsuite/gdb.python/lib-types.exp +++ b/gdb/testsuite/gdb.python/lib-types.exp @@ -92,7 +92,7 @@ gdb_test_multiple "python print (str (basic_type_class1_ref_obj))" $test { # test nested typedef stripping gdb_test_no_output "python typedef_const_typedef_class1_obj = gdb.parse_and_eval ('typedef_const_typedef_class1_obj')" gdb_test_no_output "python basic_type_typedef_const_typedef_class1_obj = gdb.types.get_basic_type (typedef_const_typedef_class1_obj.type)" -gdb_test "python print (str (typedef_class1_obj.type))" "typedef_class1" +gdb_test "python print (str (typedef_const_typedef_class1_obj.type))" "typedef_class1" set test "nested typedef stripping" gdb_test_multiple "python print (str (basic_type_typedef_const_typedef_class1_obj))" $test { -re "\[\r\n\]+class1\[\r\n\]+$gdb_prompt $" { -- 2.30.2