From 8ab82bd1fd945185de570c6853002d66d4efbbac Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Mon, 11 Feb 2019 22:36:45 -0800 Subject: [PATCH] iris: Drop XXX about checking for swizzling Caio noted that this is not necessary on Gen8+: "Before Gen8, there was a historical configuration control field to swizzle address bit[6] for in X/Y tiling modes. This was set in three different places: TILECTL[1:0], ARB_MODE[5:4], and DISP_ARB_CTL[14:13]. For Gen8 and subsequent generations, the swizzle fields are all reserved, and the CPU's memory controller performs all address swizzling modifications." Since we don't support earlier hardware, we can skip it entirely. --- src/gallium/drivers/iris/iris_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/iris/iris_screen.c b/src/gallium/drivers/iris/iris_screen.c index 728c2c23506..89f6f1bb85e 100644 --- a/src/gallium/drivers/iris/iris_screen.c +++ b/src/gallium/drivers/iris/iris_screen.c @@ -574,8 +574,7 @@ iris_screen_create(int fd) screen->precompile = env_var_as_boolean("shader_precompile", true); - bool hw_has_swizzling = false; // XXX: detect? - isl_device_init(&screen->isl_dev, &screen->devinfo, hw_has_swizzling); + isl_device_init(&screen->isl_dev, &screen->devinfo, false); screen->compiler = brw_compiler_create(screen, &screen->devinfo); screen->compiler->shader_debug_log = iris_shader_debug_log; -- 2.30.2