From 8b05b28f5a7c2ad3613fd876edd16204fd6af2cb Mon Sep 17 00:00:00 2001 From: whitequark Date: Sat, 26 Oct 2019 02:01:53 +0000 Subject: [PATCH] back.rtlil: avoid exponential behavior when legalizing Part(). Fixes #259. --- nmigen/back/rtlil.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/nmigen/back/rtlil.py b/nmigen/back/rtlil.py index bb52721..accaeb0 100644 --- a/nmigen/back/rtlil.py +++ b/nmigen/back/rtlil.py @@ -622,12 +622,19 @@ class _LHSValueCompiler(_ValueCompiler): def on_Part(self, value): offset = self.s.expand(value.offset) if isinstance(offset, ast.Const): + if offset.value == len(value.value): + dummy_wire = self.s.rtlil.wire(value.width) + return dummy_wire return self(ast.Slice(value.value, offset.value * value.stride, offset.value * value.stride + value.width)) else: + # Only so many possible parts. The amount of branches is exponential; if value.offset + # is large (e.g. 32-bit wide), trying to naively legalize it is likely to exhaust + # system resources. + max_branches = len(value.value) // value.stride + 1 raise LegalizeValue(value.offset, - range((1 << len(value.offset)) // value.stride), + range((1 << len(value.offset)) // value.stride)[:max_branches], value.src_loc) def on_Repl(self, value): -- 2.30.2