From 8bd92a15cf28714f1752fbdbafcf78f575e16f13 Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Fri, 24 Jan 2020 23:45:41 +0200 Subject: [PATCH] isl: add gen12 comment about CCS for linear tiling Signed-off-by: Lionel Landwerlin Reviewed-by: Jason Ekstrand Tested-by: Marge Bot Part-of: --- src/intel/isl/isl.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index d68ac324d07..f737f8b3b53 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -2020,6 +2020,16 @@ isl_surf_get_ccs_surf(const struct isl_device *dev, if (surf->tiling != ISL_TILING_Y0) return false; + /* BSpec 44930: + * + * Linear CCS is only allowed for Untyped Buffers but only via HDC + * Data-Port messages. + * + * We probably want to limit linear CCS to storage usage and check that + * the shaders actually use only untyped messages. + */ + assert(surf->tiling != ISL_TILING_LINEAR); + switch (isl_format_get_layout(surf->format)->bpb) { case 8: ccs_format = ISL_FORMAT_GEN12_CCS_8BPP_Y0; break; case 16: ccs_format = ISL_FORMAT_GEN12_CCS_16BPP_Y0; break; -- 2.30.2